tool: Separate argument parsing#486
Merged
Ivan-Velickovic merged 1 commit intoseL4:mainfrom May 5, 2026
Merged
Conversation
Ivan-Velickovic
force-pushed
the
viper/argparse
branch
from
5b57336 to
034af32
Compare
We separate argument parsing from main.rs. This will help refactor main, which in turn will help implementing Viper export. Signed-off-by: Zoltan A. Kocsis <11808286+zaklogician@users.noreply.github.com> Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
Ivan-Velickovic
force-pushed
the
viper/argparse
branch
from
034af32 to
e363395
Compare
Indanz
reviewed
May 5, 2026
Comment on lines
+10
to
+11
| use microkit_tool::argparse; | ||
| use microkit_tool::argparse::{Args, ArgsError, RequestedImageType}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of a series of patches which upstream Viper export to Microkit, we separate argument parsing from
main.rsintoargparse.rs.The code was refactored a bit to remove manual index manipulation. The user interface remains compatible/identical to the previous implementation.