Conversation
- Add js-tracer feature to reth-rpc-builder in workspace Cargo.toml - Enable js-tracer feature for reth-rpc-eth-api and reth-rpc-eth-types in node crate - Add js-tracer feature definition in node Cargo.toml This enables JavaScript tracer functionality for debugging transactions in the rollup node, following the pattern from scroll-tech/reth PR #334.
frisitano
reviewed
Sep 4, 2025
Contributor
frisitano
left a comment
There was a problem hiding this comment.
Added some comments inline.
Member
Author
|
Contributor
|
Why did you introduce nightly builds? |
Member
Author
I think maybe we will introduce more other features that we don't want to introduce to the stable in the future. So I name this |
Contributor
Oh I see, I had misunderstood and assumed you were using rust nightly. I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables JavaScript tracer functionality for debugging transactions in the rollup node, following the pattern from scroll-tech/reth PR #334.