Skip to content

Feat/add metric manager#296

Merged
georgehao merged 14 commits intomainfrom
feat/add_metric_manager
Sep 9, 2025
Merged

Feat/add metric manager#296
georgehao merged 14 commits intomainfrom
feat/add_metric_manager

Conversation

@georgehao
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also include the configuraiton for grafana dashboards in this PR?

@georgehao
Copy link
Copy Markdown
Member Author

Could you also include the configuraiton for grafana dashboards in this PR?

As our discussion,

  • we can merge this first
  • after most of the metrics are added, I will deploy the metrics
  • to see the effect of metric, then config on Grafana dashboard
  • export the Grafana file

I always prefer to do it like this.

frisitano
frisitano previously approved these changes Sep 8, 2025
Copy link
Copy Markdown
Contributor

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread crates/manager/src/manager/handle.rs Outdated
frisitano
frisitano previously approved these changes Sep 9, 2025
Copy link
Copy Markdown
Contributor

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: frisitano <35734660+frisitano@users.noreply.github.com>
@georgehao georgehao merged commit ee94f95 into main Sep 9, 2025
13 checks passed
@georgehao georgehao deleted the feat/add_metric_manager branch September 9, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants