fix: pick random scientific notation#491
Open
wusctong wants to merge 2 commits intoscratchfoundation:developfrom
Open
fix: pick random scientific notation#491wusctong wants to merge 2 commits intoscratchfoundation:developfrom
wusctong wants to merge 2 commits intoscratchfoundation:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Fix #160
Proposed Changes
Cast.isIntstring branch to handle scientific notation: if the string contains ane, parse it numerically to check if it's truly a whole number, otherwise fall back to the dot check.'0.1e10'fromfalsetotrue, since0.1e10equals1000000000which is a whole number.Reason for Changes
Cast.isIntonly checked for a.to decide if a string was an integer. This broke with scientific notation —5e-1has no dot but is0.5(a float), causingpick random (5e-1) to (10)to return offset values like1.5,3.5instead of proper floats.Test Coverage
Updated
util_cast.js— changedcast.isInt('0.1e10')expected value fromfalsetotrue, since0.1e10(1000000000) is a whole number and should be treated as an int.