Open
Conversation
Some sysadmins pass some global proxy configuration in the system gitconfig, and it can be useful to forward it to the container as well. This commits adds a feature to pass it by default, like the user gitconfig, and a new environment variable `CQFD_NO_SYSTEM_GIT_CONFIG` to disable it if needed. This follows the same approach as the user gitconfig or ssh forwarding.
deribaucourt
force-pushed
the
forward-system-gitconfig
branch
from
e3ae79e to
f4366b2
Compare
florentsfl
reviewed
Apr 17, 2026
Contributor
florentsfl
left a comment
florentsfl
left a comment
There was a problem hiding this comment.
Do you think that we should add some bats tests to test if the files were correctly bind mounted ? It seems like there are no tests even for the user git config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some sysadmins pass some global proxy configuration in the system gitconfig, and it can be useful to forward it to the container as well. This commits adds a feature to pass it by default, like the user gitconfig, and a new environment variable
CQFD_NO_SYSTEM_GIT_CONFIGto disable it if needed. This follows the same approach as the user gitconfig or ssh forwarding.