cqfd: allow to use a symlinked Dockerfile#260
Merged
florentsfl merged 2 commits intomasterfrom Apr 20, 2026
Merged
Conversation
florentsfl
force-pushed
the
fallard/allow-dockerfile-symlink
branch
from
1d46018 to
e1b27be
Compare
florentsfl
force-pushed
the
fallard/allow-dockerfile-symlink
branch
from
7f83e52 to
8987cd3
Compare
florentsfl
force-pushed
the
fallard/allow-dockerfile-symlink
branch
4 times, most recently
from
336f1b8 to
4e51e5b
Compare
deribaucourt
approved these changes
Apr 14, 2026
deribaucourt
requested changes
Apr 14, 2026
| #!/usr/bin/env bats | ||
|
|
||
| setup_file() { | ||
| mv .cqfd/docker/Dockerfile .cqfd/docker/Dockerfile.real |
Member
There was a problem hiding this comment.
This is temporarily destructive to the workdir, so if this test session is interrupted before the teardown is called, we are left with a broken test suite.
I suggest to instead use the cqfd -d option. It will allow you to build the symlinked Dockerfile without touching the original.
Contributor
Author
There was a problem hiding this comment.
you are right, I updated the test, and it allowed me to fix another bug where symlinks were not working when using -d. Thanks !
This commit also makes the build command more robust by always specifying the absolute path to the Dockerfile, which helps when the symlinked Dockerfile is not named as the default `Dockerfile`
The variable CQFD_DEBUG was not cleared in the Makefile so the local environment could disrupt the correct behavior of the tests when using `make tests`
florentsfl
force-pushed
the
fallard/allow-dockerfile-symlink
branch
from
4e51e5b to
e0fff81
Compare
deribaucourt
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes it possible for
.cqfd/docker/Dockerfileto be a symlink. This allows projects which already have a Dockerfile stored somewhere to make a symlink to it for cqfd.