Add more scopes#2
Closed
claytonrcarter wants to merge 8 commits intosavetheclocktower:add-php-grammarfrom
Closed
Conversation
claytonrcarter
commented
Jan 12, 2024
eg $foo->bar, in addition to $foo->$bar
47ba1b7 to
f8d0043
Compare
This was referenced Jan 12, 2024
Owner
|
OK, I updated #852 with all this feedback, including a few other things (like scoping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I had to open this here because your branch only exists in your repo, not on the main pulsar repo, which I guess makes sense. I did not add tests for these, but I did follow the sweet instructions you posted to make these edits and watch the highlights update live. 🪄
I think the commits speak for themselves, but the gist is:
interfaceabstract$foo->bar,Foo::barandFoo::$baruse Fooin a class, not as a namespace import