Skip to content

Add more scopes#2

Closed
claytonrcarter wants to merge 8 commits intosavetheclocktower:add-php-grammarfrom
claytonrcarter:add-php-grammar#crc-2
Closed

Add more scopes#2
claytonrcarter wants to merge 8 commits intosavetheclocktower:add-php-grammarfrom
claytonrcarter:add-php-grammar#crc-2

Conversation

@claytonrcarter
Copy link

Hi, I had to open this here because your branch only exists in your repo, not on the main pulsar repo, which I guess makes sense. I did not add tests for these, but I did follow the sweet instructions you posted to make these edits and watch the highlights update live. 🪄

I think the commits speak for themselves, but the gist is:

  • fix interface
  • fix abstract
  • support $foo->bar, Foo::bar and Foo::$bar
  • support trait usage, ie use Foo in a class, not as a namespace import
  • support emums
  • support missing compound operators

@savetheclocktower
Copy link
Owner

OK, I updated #852 with all this feedback, including a few other things (like scoping case in enums differently from case in switch statements). Let me know if any of this wasn't addressed in one way or another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants