Conversation
TKussel
approved these changes
Nov 7, 2025
Member
TKussel
left a comment
TKussel
left a comment
There was a problem hiding this comment.
Thank you. In the future, I would prefer to have the file logger as a separate logger, as the information I want to have persisted vs. the information, I want to see in the docker logs can differ significantly.
| impl Config { | ||
| pub fn load() -> Result<Self, SamplyBeamError> { | ||
| let cli_args = CliArgs::parse(); | ||
| pub fn load(cli_args: CliArgs) -> Result<Self, SamplyBeamError> { |
Member
There was a problem hiding this comment.
Why did you pull this into main?
Member
Author
There was a problem hiding this comment.
Because the cli args now include the log config which I did not bother to include the actual config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can be reviewed commit by commit