Skip to content

Partially document proc-macros#1029

Open
axelkar wants to merge 7 commits intosalsa-rs:masterfrom
axelkar:push-ltzowosymkyw
Open

Partially document proc-macros#1029
axelkar wants to merge 7 commits intosalsa-rs:masterfrom
axelkar:push-ltzowosymkyw

Conversation

@axelkar
Copy link
Copy Markdown

@axelkar axelkar commented Nov 21, 2025

No description provided.

This fixes a bug where code like this would break:

    type Result<T> = std::result::Result<T, MyError>;
    // or
    use std::io::Result;
    
    #[salsa::input]
    struct Example {}
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 21, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit f1d2f71
🔍 Latest deploy log https://app.netlify.com/projects/salsa-rs/deploys/69c405bf85ba0e00091feb32

@axelkar
Copy link
Copy Markdown
Author

axelkar commented Nov 21, 2025

Partially resolves #968

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Nov 21, 2025

CodSpeed Performance Report

Merging #1029 will degrade performances by 4.87%

Comparing axelkar:push-ltzowosymkyw (b602a33) with master (55e5e7d)

Summary

❌ 1 regression
✅ 12 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
amortized[SupertypeInput] 2.9 µs 3 µs -4.87%

@axelkar axelkar force-pushed the push-ltzowosymkyw branch from 52c3307 to 98eceeb Compare March 23, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant