fix(skills): Improve trigger descriptions for better auto-activation#4
fix(skills): Improve trigger descriptions for better auto-activation#4
Conversation
- hope:soul: Add DEFER TO SPECIFIC SKILLS routing guidance - product: Compress description with specific keywords (PRD, metrics, OKRs) - wordsmith: Compress description with specific keywords (edit, improve) Tested: 80% pass rate on trigger evaluation (4/5 skills trigger correctly)
PR Review: Skill Trigger Description ImprovementsSummaryThis PR improves skill auto-triggering by compressing verbose descriptions and adding routing guidance. Changes are minimal (3 files, 12 additions, 4 deletions) and well-tested (80% pass rate). Good cherry-pick strategy from #2. ✅ Strengths1. Adheres to CLAUDE.md Conventions
2. Strategic Routing in hope:soulThe DEFER TO SPECIFIC SKILLS section is smart:
3. Improved Trigger SpecificityBefore (wordsmith): "MANDATORY when user provides draft text, asks to edit prose..." Concrete keywords > vague descriptions for auto-triggering. 4. Version AlignmentPlugin.json versions match SKILL.md frontmatter:
🔴 Issues1. CHANGELOG.md Missing Entry (Blocking)Per CLAUDE.md line 116:
This is a user-facing fix affecting skill triggering. Needs entry under 2. Testing Evidence is AnecdotalPR body claims "80% pass rate (4/5 skills trigger correctly)" but no test artifacts in the PR. Consider documenting which skill failed and why (the 20%). 🟡 Suggestions (Non-blocking)1. Keyword Trigger Redundancyproduct description could be tightened by removing redundant "Triggers on product management and strategy tasks" since keywords already cover this. 2. Consistency: skill vs. SkillCLAUDE.md line 82 says "pick one term per concept." The DEFER section uses lowercase "skill" while tables use "Skill". 🔒 Security, Performance, Tests
📋 Action ItemsBefore merge:
Verdict🟡 APPROVE WITH CHANGES Solid improvement to skill triggering, well-aligned with repo conventions. Blocking issue: missing CHANGELOG.md entry. Once added, this is ready to ship. Confidence: 90% |
Summary
Cherry-picked from #2 (feat/evaluation-framework) - the valuable, low-cost changes only.
Why
Skill descriptions were too verbose/vague, causing poor auto-triggering. Compressed descriptions with specific keywords improve trigger accuracy.
Tested: 80% pass rate on trigger evaluation (4/5 skills trigger correctly)
What's NOT included
The evaluation framework (shell scripts, agents, test infrastructure) from #2 - that adds complexity without proportional value.
Test plan