Open
Conversation
Author
|
If you are not satisfied with the second commit (it is something that doesn't work 100%, I specified what in the commit message) discard it. But. please, at least merge the indicator_led option as it is an useful feature. |
Author
|
After a little more testing it actually turned out that those modifications actually messes up with the indicator LED. So I added an experimental branch (force pushed because rebase) to my fork so nothing is going to break |
- Don't ignore the return value from `rm -rf` - Use `mkdir -p` instead of ignoring return code - Delete redundant lines The `-f` option causes `rm` to silently ignore files that don't exist, so `rm -rf` will only fail if `rm` has trouble deleting a file that exists. `make` should fail in that situation. `make` should fail if the directory doesn't exist and can't be created for some reason.
Author
|
Merged the current changes to my modification so it is ready to be merged (if change is accepted) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made this pull request because it enables using other LEDs for indicating layer enabling so it avoids collisions with the actual lock state.