Skip to content

scripts: Ignore normal windows in floating window detection #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aspiers wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −0
Open

scripts: Ignore normal windows in floating window detection #1196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions scripts/keyd-application-mapper
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,7 @@ class XMonitor():
_NET_WM_STATE = self.dpy.intern_atom('_NET_WM_STATE', False)
_NET_WM_STATE_ABOVE = self.dpy.intern_atom('_NET_WM_STATE_ABOVE', False)
_NET_WM_WINDOW_TYPE_NOTIFICATION = self.dpy.intern_atom('_NET_WM_WINDOW_TYPE_NOTIFICATION', False)
_NET_WM_WINDOW_TYPE_NORMAL = self.dpy.intern_atom('_NET_WM_WINDOW_TYPE_NORMAL', False)
_NET_WM_WINDOW_TYPE = self.dpy.intern_atom('_NET_WM_WINDOW_TYPE', False)

def get_floating_window():
Expand All @@ -394,9 +395,16 @@ class XMonitor():

if v and v.value and v.value[0] == _NET_WM_STATE_ABOVE:
types = w.get_full_property(_NET_WM_WINDOW_TYPE, Xlib.Xatom.ATOM)
wm_class = w.get_wm_class()

# Ignore normal windows
if types and _NET_WM_WINDOW_TYPE_NORMAL in types.value:
dbg(f'skipping normal window: {wm_class}')
continue

# Ignore persistent notification windows like dunst
if not types or _NET_WM_WINDOW_TYPE_NOTIFICATION not in types.value:
dbg(f'get_floating_window found: {wm_class}')
return w

return None
Expand Down