Skip to content

Fix errors due to review changes link in review comments #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Urgau merged 2 commits into from
Apr 7, 2026
+13 −3
Merged

Fix errors due to review changes link in review comments #2367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b34d4c
Only trigger on reviews and review comments, not normal comments
Urgau Apr 7, 2026
69b814e
Add SCREAMING_CASE aliases for `PullRequestReviewState`
Urgau Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/github/issue.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ impl Issue {
let review = client
.json(client.get(&review_url))
.await
.context("unable to fetch review")?;
.with_context(|| format!("unable to fetch review ({review_id})"))?;
Ok(review)
}
}
Expand Down Expand Up @@ -663,10 +663,15 @@ pub struct Comment {
#[derive(Debug, serde::Deserialize, Eq, PartialEq)]
#[serde(rename_all = "snake_case")]
pub enum PullRequestReviewState {
#[serde(alias = "APPROVED")]
Approved,
#[serde(alias = "CHANGES_REQUESTED")]
ChangesRequested,
#[serde(alias = "COMMENTED")]
Commented,
#[serde(alias = "DISMISSED")]
Dismissed,
#[serde(alias = "PENDING")]
Pending,
}

Expand Down
9 changes: 7 additions & 2 deletions src/handlers/review_changes_since.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@ pub(crate) async fn handle(
..
},
) = event
&& (
// review
event.comment.pr_review_state.is_some()
// review comments
|| event.comment.pull_request_review_id.is_some()
)
{
let issue_repo = event.issue.repository();
let pr_num = event.issue.number;
Expand All @@ -58,8 +64,7 @@ pub(crate) async fn handle(

let link = format!("https://{host}/gh-changes-since/{issue_repo}/{pr_num}/{base}..{head}");

if event.comment.pull_request_review_id.is_none() && event.comment.pr_review_state.is_some()
{
if event.comment.pr_review_state.is_some() {
// this is a review (not a review comment)

{
Expand Down