feat: add optional tracing performance spans#125
Merged
GuillaumeGomez merged 4 commits intorust-lang:mainfrom May 5, 2026
Merged
feat: add optional tracing performance spans#125GuillaumeGomez merged 4 commits intorust-lang:mainfrom
GuillaumeGomez merged 4 commits intorust-lang:mainfrom
Conversation
| ManagedByRustwide(PathBuf), | ||
| } | ||
|
|
||
| impl fmt::Debug for Binary { |
Member
There was a problem hiding this comment.
Please add a code comment explaining why you didn't derive it instead (I suppose it's because you want to skip the enum's name but please still write it down).
Member
Author
There was a problem hiding this comment.
I was thinking too much yesterday, changed to be the derive
GuillaumeGomez
approved these changes
May 5, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to dig deeper on optimizing build speed, and first step is measuring where exactly we spend time.