You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Interestingly, it looks like a number of the tests time out on my macOS machine when run as part of a full cargo test --features test (even on main):
test download::tests::reqwest::network_failure_does_not_delete_partial_file has been running for over 60 seconds
test download::tests::reqwest::read_basic_proxy_params has been running for over 60 seconds
test download::tests::reqwest::resume_partial_fails_if_server_ignores_range has been running for over 60 seconds
test download::tests::reqwest::socks_proxy_request has been running for over 60 seconds
test download::tests::reqwest::network_failure_does_not_delete_partial_file ... ok
although they work okay when running cargo test --features test download::tests.
Interestingly, it looks like a number of the tests time out on my macOS machine when run as part of a full cargo test --features test (even on main):
test download::tests::reqwest::network_failure_does_not_delete_partial_file has been running for over 60 seconds
test download::tests::reqwest::read_basic_proxy_params has been running for over 60 seconds
test download::tests::reqwest::resume_partial_fails_if_server_ignores_range has been running for over 60 seconds
test download::tests::reqwest::socks_proxy_request has been running for over 60 seconds
test download::tests::reqwest::network_failure_does_not_delete_partial_file ... ok
although they work okay when running cargo test --features test download::tests.
@djc Cannot reproduce on my machine here. Do you happen to have HTTP_PROXY set? Because scrub_env() forgot to scrub it for some reason...
But it does make sense because any test currently relying on scrub_env() is behind a lock (#4372). One waits for another when other stuff is running... It is possible for this to get over 60s as long as they eventually pass.
The reason will be displayed to describe this comment to others. Learn more.
Note to the future reviewer: the test right above is already a direct-style download resumption test, so it's safe to delete this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up to
Interestingly, it looks like a number of the tests time out on my macOS machine when run as part of a full
cargo test --features test(even onmain):although they work okay when running
cargo test --features test download::tests.