Skip to content

fix(dist): propagate v2 manifest checksum failure #4830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cachebag wants to merge 2 commits into
base: main
Choose a base branch
from
+73 −1
Open

fix(dist): propagate v2 manifest checksum failure #4830

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa00dd1
fix(dist): propagate v2 manifest checksum failure instead of reportin…
cachebag Apr 24, 2026
c4e5121
test(dist): fail v2 manifest update when manifest disagrees with .sha256
cachebag Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/dist/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1234,11 +1234,15 @@ async fn try_update_from_dist_(
Ok(None) => return Ok(None),
Err(err) => {
match err.downcast_ref::<RustupError>() {
Some(RustupError::ChecksumFailed { .. }) => return Ok(None),
Some(RustupError::DownloadNotExists { .. }) => {
// Proceed to try v1 as a fallback
debug!("manifest not found; trying legacy manifest");
}
// Includes `ChecksumFailed`: if the v2 manifest exists but its
// contents do not match the published `.sha256`, surface the
// integrity failure as an error rather than silently treating
// the toolchain as up to date. The v1 fallback path below
// already does the same.
_ => return Err(err),
}
}
Expand Down
Loading