-
Notifications
You must be signed in to change notification settings - Fork 584
Updated dates #2796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated dates #2796
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,7 @@ which boils down to a static with type [`&rustc_lint_defs::Lint`] | |
| as the macro is somewhat unwieldy to add new fields to, | ||
| like all macros). | ||
|
|
||
| As of <!-- date-check --> Aug 2022, | ||
| As of <!-- date-check --> March 2026, | ||
| we lint against direct declarations without the use of the macro. | ||
|
Comment on lines
-24
to
25
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. have you verified this is still true?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jyn514 (https://github.com/rust-lang/rust/blob/main/compiler/rustc_lint/src/lib.rs) i checked the above lib.rs looks like we are still using LINT_PASS_IMPL_WITHOUT_MACRO so i guess this is still true because this will act as global identifier. Any thoughts ?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cool. since there's no dates involved in the code, I think we should remove the date and just start the sentence with "We lint against ...". This is not changing so rapidly that we need to regularly check on it.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. got it, i was thinking the same if its not statically changing we should just remove it. Other changes looks good ? |
||
|
|
||
| Lint declarations don't carry any "state" - they are merely global identifiers | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.