Rollup of 4 pull requests by JonathanBrouwer · Pull Request #156324 · rust-lang/rust

JonathanBrouwer · 2026-05-08T14:18:43Z

Successful merges:

Introduce a RerunNonErased error type mirroring NoSolution, to better track when we're bailing #156246 (Introduce a RerunNonErased error type mirroring NoSolution, to better track when we're bailing)
turn compute_goal_fast_path into a single match #156038 (turn compute_goal_fast_path into a single match)
Treat MSVC "performing full link" message as informational #156291 (Treat MSVC "performing full link" message as informational)
Avoid ICE when suggesting as_ref for ill-typed closure receivers #156301 (Avoid ICE when suggesting as_ref for ill-typed closure receivers)

When the MSVC incremental linker finds a .ilk file for incremental linking but its associated .exe file is missing, this message is printed to stdout in 1 line: LINK : ...\foo.exe not found or not build by the last incremental link; performing full link However, if both the .ilk and .exe files are missing (for a clean build), the message isn't printed and it still does a full link. So, the presence of the message doesn't affect the result of the build.

… type

@lcnr

Introduce a `RerunNonErased` error type mirroring `NoSolution`, to better track when we're bailing r? @lcnr @rustbot blocked rust-lang#155443

@lcnr

…h, r=lcnr turn `compute_goal_fast_path` into a single match r? @lcnr @rustbot blocked on rust-lang#155443

@mati865

…mati865 Treat MSVC "performing full link" message as informational When the MSVC incremental linker finds a .ilk file for incremental linking but its associated .exe file is missing, this message is printed to stdout: ```text LINK : ...\foo.exe not found or not build by the last incremental link; performing full link ``` However, if both the .ilk and .exe files are missing (for a clean build), the message isn't printed and it still does a full link. So, the presence of the message doesn't affect the result of the build. See rust-lang#156209 for further context. r? @mati865 cc @jyn514

…r-suggestion-ice, r=wesleywiser Avoid ICE when suggesting as_ref for ill-typed closure receivers Fixes rust-lang#156299 When building mismatch suggestions, `can_use_as_ref` may inspect the receiver of a method call that is itself an ill-typed closure expression. In that recovery path, the receiver may not have a recorded type in `TypeckResults`. Use `expr_ty_opt` instead of `expr_ty` so the optional `as_ref()` suggestion is skipped when the receiver type is unavailable.

JonathanBrouwer · 2026-05-08T14:18:50Z

@bors r+ rollup=never p=5

rust-bors · 2026-05-08T14:18:53Z

📌 Commit 01cccf9 has been approved by JonathanBrouwer

It is now in the queue for this repository.

rust-bors · 2026-05-08T18:24:14Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 27m 7s
Pushing 8068e2f to main...

rust-timer · 2026-05-08T18:25:28Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#156038	turn `compute_goal_fast_path` into a single match	`eeab4df55a2c218f62f2c8e9e98287fddaae1500` (link)
#156246	Introduce a `RerunNonErased` error type mirroring `NoSoluti…	`9b178baa826b6f938f346a34c2d13ba3732ab315` (link)
#156291	Treat MSVC "performing full link" message as informational	`41d22797469f0300f2ef51664690b6ff68c30db2` (link)
#156301	Avoid ICE when suggesting as_ref for ill-typed closure rece…	`9f0021be646f84eb59de581ed6bb4f4b1b2312ed` (link)

previous master: f2b291d902

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-05-08T18:27:19Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f2b291d (parent) -> 8068e2f (this PR)

Test differences

Show 51 test diffs

Stage 1

[run-make] tests/run-make/msvc-incremental-full-link-info: [missing] -> ignore (only executed when the target environment is msvc) (J1)
[ui] tests/ui/closures/closure-arg-type-mismatch-method-receiver.rs: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/closures/closure-arg-type-mismatch-method-receiver.rs: [missing] -> pass (J0)
[run-make] tests/run-make/msvc-incremental-full-link-info: [missing] -> ignore (only executed when the target environment is msvc) (J2)
[run-make] tests/run-make/msvc-incremental-full-link-info: [missing] -> pass (J3)

Additionally, 46 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 8068e2fc9afa8c888336b12db01987be768785f9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

optional-x86_64-gnu-parallel-frontend: 2h 13m -> 3h 10m (+41.9%)
armhf-gnu: 1h 8m -> 1h 35m (+40.7%)
x86_64-gnu-llvm-22-3: 1h 30m -> 2h 1m (+34.9%)
x86_64-msvc-ext3: 1h 22m -> 1h 49m (+32.1%)
i686-gnu-nopt-2: 1h 45m -> 2h 17m (+29.9%)
x86_64-msvc-1: 2h 5m -> 2h 38m (+27.1%)
dist-arm-linux-musl: 1h 18m -> 1h 39m (+26.6%)
dist-aarch64-apple: 2h 56m -> 2h 12m (-25.0%)
x86_64-msvc-2: 2h 33m -> 1h 55m (-24.8%)
dist-apple-various: 2h 39m -> 2h 1m (-24.1%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-05-08T19:05:59Z

Finished benchmarking commit (8068e2f): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	1
Regressions ❌ (secondary)	0.3%	[0.2%, 0.3%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.5%	[-1.5%, -1.5%]	1
All ❌✅ (primary)	0.3%	[0.3%, 0.3%]	1

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (primary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.1%	[-2.1%, -2.1%]	1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 497.331s -> 498.048s (0.14%)
Artifact size: 395.05 MiB -> 397.10 MiB (0.52%)

Adds the missing primitives so claudette can drive the full clone→fix→fork→push→PR loop on any GitHub repo conversationally, without orchestration glue. New tools (all wired into permission policy + gitops agent): - git_clone(url, dest, depth?) — clones into ~/.claudette/missions/<dest>/ with URL-scheme allowlist (https/http/git@/ssh) and dest-slug validation (no ../slashes/colons), 120s timeout, half-clone cleanup on failure - gh_list_repo_issues(owner, repo, state?, labels?, limit?) — browses any repo's open issues, PRs filtered out, capped at 30 - gh_pr_status(owner, repo, number) — state/draft/merged/mergeable plus head_ref/head_sha/base_ref - gh_fork(owner, repo) — POSTs /forks, returns clone_url + async-warning - gh_create_pr(owner, repo, title, body, head, base, draft?) — head is 'branch' (same-repo) or 'username:branch' (fork) +14 unit tests covering missing-field rejection, URL-scheme allowlist, dest-slug traversal/colon/slash rejection, schema-list bumps to 9 (Git) and 10 (Github), gitops-config-has-brownfield-tools. Live-validated 4/5 against real GitHub endpoints (gh_list_repo_issues on mrdushidush/claudette, gh_pr_status on rust-lang/rust#156324, git_clone of octocat/Hello-World, gh_fork creating mrdushidush/Hello-World). gh_create_pr unit-tested only — opening a real PR is for the next session. 664/670 lib tests pass, clippy clean with -D warnings, fmt clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

kupiakos and others added 10 commits May 7, 2026 13:59

add regression test for closure receiver suggestion ICE

83d39fb

avoid ICE in as_ref suggestion for untyped receiver

d467037

refactor compute_goal_fast_path: turn into a single match

644250d

return faster from internal iterators

687f839

consistently encode failure reason (nosolution or rerun) in the error…

180725c

… type

Rollup merge of rust-lang#156246 - jdonszelmann:rerun-error-type, r=lcnr

fd16638

Introduce a `RerunNonErased` error type mirroring `NoSolution`, to better track when we're bailing r? @lcnr @rustbot blocked rust-lang#155443

Rollup merge of rust-lang#156038 - jdonszelmann:fast-path-single-matc…

ffe32f0

…h, r=lcnr turn `compute_goal_fast_path` into a single match r? @lcnr @rustbot blocked on rust-lang#155443

rust-bors Bot added the rollup A PR which is a rollup label May 8, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 8, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 8, 2026

rust-bors Bot merged commit 8068e2f into rust-lang:main May 8, 2026
12 checks passed

rustbot added this to the 1.97.0 milestone May 8, 2026

This was referenced May 8, 2026

-Zassumptions-on-binders #155887

Open

Pass the whole GenericArgs to Interner::for_each_relevant_impl() #156295

Open

Dont bail in error predicate unless self ty is error in new solver #150453

Open

This was referenced May 8, 2026

Fix ICE when using Iterator in const contexts #152242

Open

test new solver on CI until stabilization #156146

Open

Binder instantiation returns Unnormalized #156221

Open

rustbot added the perf-regression Performance regression. label May 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 4 pull requests#156324

Rollup of 4 pull requests#156324
rust-bors[bot] merged 10 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-HKA8242

JonathanBrouwer commented May 8, 2026

Uh oh!

JonathanBrouwer commented May 8, 2026

Uh oh!

rust-bors Bot commented May 8, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 8, 2026

Uh oh!

Uh oh!

rust-timer commented May 8, 2026

Uh oh!

github-actions Bot commented May 8, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

JonathanBrouwer commented May 8, 2026

Uh oh!

JonathanBrouwer commented May 8, 2026

Uh oh!

rust-bors Bot commented May 8, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 8, 2026

Uh oh!

Uh oh!

rust-timer commented May 8, 2026

Uh oh!

github-actions Bot commented May 8, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented May 8, 2026

Overall result: ❌✅ regressions and improvements - please read:

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants