Rollup of 3 pull requests#156303
Closed
JonathanBrouwer wants to merge 7 commits intorust-lang:mainfrom
Closed
Conversation
All the necessary data can be taken from `SyntaxExtension` instead.
Clone only on interface boundaries with `rustc_expand`
This is consistent with our use of `widening` elsewhere. Suggested-by: Gabriel Bjørnager Jensen <gabriel@achernar.io>
resolve: Remove `MacroData` All the necessary data can be taken from `SyntaxExtension` instead.
Rename the unstable integer `extend` function to `widen` This is consistent with our use of `widening` elsewhere. Suggested-by: Gabriel Bjørnager Jensen <gabriel@achernar.io>
…to-run-incr, r=nnethercote Do not cache `lints_that_dont_need_to_run` across sessions The `lints_that_dont_need_to_run` query depends on the lint store (which includes internal lints under `-Zunstable-options`). Because that flag is deliberately not part of the incremental command-line hash, incremental builds could load stale results from sessions with a different lint configuration, leading to an ICE. This PR marks the query `eval_always` so it is recomputed for the current session instead of being loaded from cache. Fixes rust-lang#156182.
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
💔 Test for 4bf7faf failed: CI. Failed job:
|
Contributor
|
This pull request was unapproved due to being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
MacroData#156236 (resolve: RemoveMacroData)extendfunction towiden#156298 (Rename the unstable integerextendfunction towiden)lints_that_dont_need_to_runacross sessions #156214 (Do not cachelints_that_dont_need_to_runacross sessions)r? @ghost
Create a similar rollup