Skip to content

Move feature* methods from parse mod to errors mod.#155980

Open
nnethercote wants to merge 1 commit intorust-lang:mainfrom
nnethercote:mv-feature-methods
Open

Move feature* methods from parse mod to errors mod.#155980
nnethercote wants to merge 1 commit intorust-lang:mainfrom
nnethercote:mv-feature-methods

Conversation

@nnethercote
Copy link
Copy Markdown
Contributor

As the FIXME comment says, these no longer use ParseSess and so the parse mod is not a good place for them. The errors mod is a better home.

r? @TaKO8Ki

As the FIXME comment says, these no longer use `ParseSess` and so the
`parse` mod is not a good place for them. The `errors` mod is a better
home.
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 30, 2026

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

HIR ty lowering was modified

cc @fmease

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred to constck

cc @fee1-dead

changes to the core type system

cc @lcnr

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 30, 2026
@TaKO8Ki
Copy link
Copy Markdown
Member

TaKO8Ki commented Apr 30, 2026

@nnethercote This is not blocking, but rustc-dev-guide still mentions rustc_session::parse::feature_err.

https://github.com/rust-lang/rustc-dev-guide/blob/b1026059fb05aa7bd2d9380d444ff864b3a449cc/src/implementing-new-features.md?plain=1#L194

@TaKO8Ki
Copy link
Copy Markdown
Member

TaKO8Ki commented Apr 30, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 30, 2026

📌 Commit 6d79bc6 has been approved by TaKO8Ki

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants