Skip to content

Add mention of sendfile(2) and splice(2) to fs::copy() documentation. #155970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomilepp wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Add mention of sendfile(2) and splice(2) to fs::copy() documentation. #155970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions library/std/src/fs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2790,8 +2790,9 @@ pub fn rename<P: AsRef<Path>, Q: AsRef<Path>>(from: P, to: Q) -> io::Result<()>
/// with `O_RDONLY` for `from` and `O_WRONLY`, `O_CREAT`, and `O_TRUNC` for `to`.
/// `O_CLOEXEC` is set for returned file descriptors.
///
/// On Linux (including Android), this function attempts to use `copy_file_range(2)`,
/// and falls back to reading and writing if that is not possible.
/// On Linux (including Android), this function uses copy_file_range(2),
/// sendfile(2) or splice(2) syscalls to move data directly between files
Copy link
Copy Markdown
Member

@joshtriplett joshtriplett May 2, 2026 •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// sendfile(2) or splice(2) syscalls to move data directly between files
/// sendfile(2), or splice(2) syscalls to move data directly between files

(Oxford comma.)

View changes since the review

/// if possible.
///
/// On Windows, this function currently corresponds to `CopyFileEx`. Alternate
/// NTFS streams are copied but only the size of the main stream is returned by
Expand Down
Loading