rustdoc: preserve parent doc cfg for macro_export macros#155954
Open
cijiugechu wants to merge 1 commit intorust-lang:mainfrom
Open
rustdoc: preserve parent doc cfg for macro_export macros#155954cijiugechu wants to merge 1 commit intorust-lang:mainfrom
macro_export macros#155954cijiugechu wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @notriddle rustbot has assigned @notriddle. Use Why was this reviewer chosen?The reviewer was selected based on:
|
cijiugechu
commented
Apr 29, 2026
|
|
||
| /// This function goes through the attributes list (`new_attrs`) and extracts the attributes that | ||
| /// affect the cfg state propagated to detached items. | ||
| fn add_cfg_state_attributes(attrs: &mut Vec<Attribute>, new_attrs: &[Attribute]) { |
Member
Author
There was a problem hiding this comment.
I kept them(this function and add_only_cfg_attributes) separate because a shared helper would make the logic harder to follow.
cijiugechu
changed the title
macro_export macros
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The detached-item context is discovered before
propagate_doc_cfg, it is carried on the clean item and consumed by the pass.Closes #100916