delegation: generate only used parent generics in method call scenario#155906
Open
aerooneqq wants to merge 1 commit intorust-lang:mainfrom
Open
delegation: generate only used parent generics in method call scenario#155906aerooneqq wants to merge 1 commit intorust-lang:mainfrom
aerooneqq wants to merge 1 commit intorust-lang:mainfrom
Conversation
Contributor
|
We talked with @aerooneqq and decided to try always lowering into free function calls instead of method calls, this way we'll always be able to propagate generics. |
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Contributor
|
☔ The latest upstream changes (presumably #155018) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports generating only used parent generics in method call scenario. At the current state we always generated all generic params in method call scenario, even if some of them were not used in signature or predicates. Now we determine the set of generic params which are either used in function signature or in predicates and generate only them.
As we see from an example we did not generate
Cparam (alsoAandB) as it is not used in signature and predicates, but we generated lifetimesaandbasbis used in signature (b: &'b str) andais used inb's predicate ('b: 'static + 'a).If we use
Aparam somewhere infoofunction (i.e., instead off: impl FnOnce() -> usizewe would havef: impl FnOnce() -> A), then we generate bothAandB, asBparticipates in predicateA: Bound<B>.Also this PR finally removed
into_hir_genericscalls fromall_paramsandall_predicates, now it works as designed.Part of #118212.
r? @petrochenkov