Rollup of 2 pull requests#155807
Closed
jhpratt wants to merge 5 commits intorust-lang:mainfrom
Closed
Conversation
it is not as important anymore (see next comment)
…r=jhpratt Document that `ManuallyDrop`'s `Box` interaction has been fixed Both rust-lang#150447 and rust-lang#150446 has been merged in `1.96.0`, fixing the unfortunate `ManuallyDrop<Box<_>>` behavior. cc @RalfJung
std: maintain `CStringArray` null-termination even if `Vec::push` panics Fixes rust-lang#155748 by performing the `push` of the new null terminator before overwriting the previous one.
rustbot
added
S-waiting-on-review
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit 5f2e748 with merge b38b620... Workflow: https://github.com/rust-lang/rust/actions/runs/24951157121 |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
PR #155750, which is a member of this rollup, was unapproved. This rollup was thus unapproved. Auto build was cancelled due to unapproval. Cancelled workflows: |
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ManuallyDrop'sBoxinteraction has been fixed #155750 (Document thatManuallyDrop'sBoxinteraction has been fixed)CStringArraynull-termination even ifVec::pushpanics #155774 (std: maintainCStringArraynull-termination even ifVec::pushpanics)r? @ghost
Create a similar rollup