When archive format is wrong produce an error instead of ICE#155721
Open
cezarbbb wants to merge 1 commit intorust-lang:mainfrom
Open
When archive format is wrong produce an error instead of ICE#155721cezarbbb wants to merge 1 commit intorust-lang:mainfrom
cezarbbb wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-run-make
Collaborator
|
bjorn3
reviewed
Apr 25, 2026
bjorn3
reviewed
Apr 25, 2026
Member
|
Let’s check that the test doesn’t cause problems on non-Linux hosts: @bors try jobs=aarch64-apple,x86_64-msvc-1,aarch64-msvc-1 |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 26, 2026
When archive format is wrong produce an error instead of ICE try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: aarch64-msvc-1
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
💔 Test for f7f24db failed: CI. Failed jobs:
|
bjorn3
reviewed
Apr 28, 2026
bjorn3
reviewed
Apr 28, 2026
bjorn3
reviewed
Apr 28, 2026
bjorn3
reviewed
Apr 28, 2026
bjorn3
reviewed
Apr 28, 2026
bjorn3
reviewed
Apr 28, 2026
bjorn3
reviewed
Apr 28, 2026
bjorn3
reviewed
Apr 28, 2026
Member
|
@bors try jobs=aarch64-apple,x86_64-msvc-1,aarch64-msvc-1 r=me if the try run succeeds |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 29, 2026
When archive format is wrong produce an error instead of ICE try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: aarch64-msvc-1
Contributor
Author
|
When the test is successful, I will squash the four commits together into one and then force-push again. |
Contributor
cezarbbb
force-pushed
the
fix-archive-ice-148217
branch
2 times, most recently
from
b8c6eb0 to
b784a1c
Compare
Member
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 29, 2026
…=bjorn3 When archive format is wrong produce an error instead of ICE Fix rust-lang#145624. Fix rust-lang#147094. Fix rust-lang#148217. There are now two-step solutions to replace the original ICE： Step 1: BSD format archive on a GNU/Linux target should emit a format mismatch warning. Step 2: Corrupt archive with member offset exceeding file boundary should produce an error, not an ICE. r? @bjorn3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
Fix #145624. Fix #147094. Fix #148217.
There are now two-step solutions to replace the original ICE：
Step 1: BSD format archive on a GNU/Linux target should emit a format mismatch warning.
Step 2: Corrupt archive with member offset exceeding file boundary should produce an error, not an ICE.
r? @bjorn3