Skip to content

Add str::word_to_titlecase() to alloc#155705

Open
Jules-Bertholet wants to merge 2 commits intorust-lang:mainfrom
Jules-Bertholet:word-to-titlecase
Open

Add str::word_to_titlecase() to alloc#155705
Jules-Bertholet wants to merge 2 commits intorust-lang:mainfrom
Jules-Bertholet:word-to-titlecase

Conversation

@Jules-Bertholet
Copy link
Copy Markdown
Contributor

A small addition to #153892.

Hasn't gone through ACP, so needs libs-API signoff.

@rustbot label A-Unicode T-libs-api

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 23, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 23, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 6 candidates
  • Random selection from Mark-Simulacrum, jhpratt

@rustbot rustbot added A-Unicode Area: Unicode T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Apr 23, 2026
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-t-libs-api Status: Awaiting decision from T-libs-api and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2026
@Jules-Bertholet Jules-Bertholet force-pushed the word-to-titlecase branch 2 times, most recently from 2753869 to 3a6aeb6 Compare April 26, 2026 14:55
Comment thread library/alloc/src/str.rs Outdated
@the8472
Copy link
Copy Markdown
Member

the8472 commented Apr 28, 2026

We discussed it during today's libs-api meeting. We didn't do an in-depth review, but we're generally ok with having this on unstable.

Also, the issue title was confusing since it adds a String method, not one on char.

@Jules-Bertholet Jules-Bertholet changed the title Add char::word_to_titlecase() to alloc Add str::word_to_titlecase() to alloc Apr 28, 2026
@Jules-Bertholet
Copy link
Copy Markdown
Contributor Author

Also, the issue title was confusing since it adds a String method, not one on char.

🤦 Sorry…

@Jules-Bertholet
Copy link
Copy Markdown
Contributor Author

Jules-Bertholet commented Apr 29, 2026

@rustbot ready
@rustbot label -S-waiting-on-t-libs-api

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-t-libs-api Status: Awaiting decision from T-libs-api labels Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Unicode Area: Unicode S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants