Skip to content

Add a missing GenericTypeVisitable, and avoid having interner traits for FnSigKind and Abi#155562

Open
ChayimFriedman2 wants to merge 2 commits intorust-lang:mainfrom
ChayimFriedman2:no-traits
Open

Add a missing GenericTypeVisitable, and avoid having interner traits for FnSigKind and Abi#155562
ChayimFriedman2 wants to merge 2 commits intorust-lang:mainfrom
ChayimFriedman2:no-traits

Conversation

@ChayimFriedman2
Copy link
Copy Markdown
Contributor

@ChayimFriedman2 ChayimFriedman2 commented Apr 20, 2026

r? types

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 20, 2026

HIR ty lowering was modified

cc @fmease

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a, @makai410

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 20, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 20, 2026

The Miri subtree was changed

cc @rust-lang/miri

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 21, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ChayimFriedman2
Avoid having traits in rustc_type_ir for FnSigKind and Abi
83b29b6 
Instead, just use the concrete types `FnSigKind` and `rustc_abi::ExternAbi`. This simplifies the code in both rustc and rust-analyzer.
oli-obk
oli-obk reviewed Apr 22, 2026
View reviewed changes
Comment thread compiler/rustc_type_ir/src/ty_kind.rs
nikomatsakis
nikomatsakis approved these changes Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@nikomatsakis nikomatsakis left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a win to me.

If I'm following, @ChayimFriedman2, this basically gives you more shared code that can be reused?

View changes since this review

@ChayimFriedman2
Copy link
Copy Markdown
Contributor Author

ChayimFriedman2 commented Apr 27, 2026

Yes. As long as r-a and rustc don't need to diverge, we should prefer to share the code.

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 28, 2026

☔ The latest upstream changes (presumably #155329) made this pull request unmergeable. Please resolve the merge conflicts.

teor2345
teor2345 approved these changes Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@teor2345 teor2345 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I was trying to work out how to do something like this in the original refactor, but couldn't quite get it to work.

Do you think there's much risk of a perf regression from #155223?

View changes since this review

@ChayimFriedman2
Copy link
Copy Markdown
Contributor Author

ChayimFriedman2 commented Apr 29, 2026

Do you think there's much risk of a perf regression from #155223?

How will this regress perf?

@nikomatsakis
Copy link
Copy Markdown
Contributor

nikomatsakis commented Apr 29, 2026

@bors delegate+

r=me once this is rebased etc.

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 29, 2026

✌️ @ChayimFriedman2, you can now approve this pull request!

If @nikomatsakis told you to "r=me" after making some further change, then please make that change and post @bors r=nikomatsakis.

View changes since this delegation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obk oli-obk oli-obk left review comments

@nikomatsakis nikomatsakis nikomatsakis approved these changes

+1 more reviewer

@teor2345 teor2345 teor2345 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nikomatsakis nikomatsakis

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ChayimFriedman2 @rustbot @rust-log-analyzer @nikomatsakis @oli-obk @teor2345