remove new_from_def_id and alias_ty_kind_from_def_id#155371
Draft
josetorrs wants to merge 1 commit intorust-lang:mainfrom
Draft
remove new_from_def_id and alias_ty_kind_from_def_id#155371josetorrs wants to merge 1 commit intorust-lang:mainfrom
new_from_def_id and alias_ty_kind_from_def_id#155371josetorrs wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-author
Collaborator
|
|
josetorrs
commented
Apr 16, 2026
| | ty::AliasTermKind::InherentConst | ||
| | ty::AliasTermKind::FreeConst | ||
| | ty::AliasTermKind::UnevaluatedConst => { | ||
| unreachable!() |
Contributor
Author
There was a problem hiding this comment.
admittedly not sure if unreachable!() or something else is desired
1 task
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
josetorrs
force-pushed
the
add-alias-term-kind-to-type-relative-path
branch
from
5327d39 to
deb0af0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @WaffleLapkin
related issue: #154941
tackling the task:
new_from_def_idandalias_ty_kind_from_def_idand replace them with calls to e.g.new_projectiondirectlymainly raising as an alternative to #155323