[EXPERIMENT] Introduce `TypingMode::Codegen` to avoid layout cycles by cjgillot · Pull Request #145477 · rust-lang/rust

cjgillot · 2025-08-16T00:04:12Z

cjgillot · 2025-08-16T00:05:55Z

[EXPERIMENT] Introduce `TypingMode::Codegen` to avoid layout cycles

rust-bors · 2025-08-16T02:19:21Z

☀️ Try build successful (CI)
Build commit: 34dd67f (34dd67f42f0f2050c773b332e2dd333618c22743, parent: cd7cbe818e4a66d46fe2df993d1b8518eba8a5cd)

rust-timer · 2025-08-16T07:24:00Z

Finished benchmarking commit (34dd67f): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.2%, 3.3%]	58
Regressions ❌ (secondary)	1.8%	[0.0%, 19.4%]	58
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.0%]	4
All ❌✅ (primary)	0.5%	[0.2%, 3.3%]	58

Max RSS (memory usage)

Results (primary 1.4%, secondary 4.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.7%	[0.5%, 7.3%]	17
Regressions ❌ (secondary)	5.4%	[1.2%, 12.3%]	6
Improvements ✅ (primary)	-1.3%	[-1.4%, -1.3%]	2
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	1
All ❌✅ (primary)	1.4%	[-1.4%, 7.3%]	19

Cycles

Results (primary 2.9%, secondary 4.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.9%, 2.9%]	1
Regressions ❌ (secondary)	5.3%	[2.1%, 12.0%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.0%	[-4.0%, -4.0%]	1
All ❌✅ (primary)	2.9%	[2.9%, 2.9%]	1

Binary size

Results (primary 0.1%, secondary -1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.1%, 0.6%]	2
Regressions ❌ (secondary)	0.3%	[0.1%, 0.4%]	3
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	3
Improvements ✅ (secondary)	-1.8%	[-7.1%, -0.1%]	5
All ❌✅ (primary)	0.1%	[-0.0%, 0.6%]	5

Bootstrap: 469.562s -> 472.464s (0.62%)
Artifact size: 377.55 MiB -> 377.67 MiB (0.03%)

cjgillot · 2025-08-16T14:48:02Z

@bors try @rust-timer queue

[EXPERIMENT] Introduce `TypingMode::Codegen` to avoid layout cycles

rust-bors · 2025-08-16T17:07:25Z

☀️ Try build successful (CI)
Build commit: 4e9488c (4e9488c147d4057600076145eccb670b130147d5, parent: 2e2642e641a941f0a1400c7827fd89aa86fef8f4)

rust-timer · 2025-08-16T18:40:34Z

Finished benchmarking commit (4e9488c): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 0.9%]	23
Regressions ❌ (secondary)	1.5%	[0.1%, 9.7%]	59
Improvements ✅ (primary)	-1.6%	[-1.6%, -1.6%]	1
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	2
All ❌✅ (primary)	0.4%	[-1.6%, 0.9%]	24

Max RSS (memory usage)

Results (primary 1.7%, secondary 5.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.9%	[0.5%, 7.5%]	19
Regressions ❌ (secondary)	6.6%	[0.4%, 12.9%]	5
Improvements ✅ (primary)	-1.3%	[-1.3%, -1.3%]	1
Improvements ✅ (secondary)	-2.8%	[-2.8%, -2.8%]	1
All ❌✅ (primary)	1.7%	[-1.3%, 7.5%]	20

Cycles

Results (secondary 2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.2%	[2.1%, 10.2%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.8%, -2.2%]	2
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.0%, secondary -1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	1
Regressions ❌ (secondary)	0.2%	[0.1%, 0.4%]	4
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	3
Improvements ✅ (secondary)	-2.9%	[-6.8%, -0.0%]	3
All ❌✅ (primary)	0.0%	[-0.0%, 0.1%]	4

Bootstrap: 470.222s -> 472.094s (0.40%)
Artifact size: 377.51 MiB -> 377.42 MiB (-0.02%)

bors · 2025-08-23T06:22:24Z

☔ The latest upstream changes (presumably #145469) made this pull request unmergeable. Please resolve the merge conflicts.

rust-timer · 2025-10-17T21:13:00Z

Finished benchmarking commit (aff7f6c): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.1%, 1.0%]	48
Regressions ❌ (secondary)	1.7%	[0.1%, 9.7%]	48
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	0.4%	[0.1%, 1.0%]	48

Max RSS (memory usage)

Results (primary 2.5%, secondary -1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.8%	[0.8%, 10.4%]	10
Regressions ❌ (secondary)	1.9%	[1.9%, 1.9%]	1
Improvements ✅ (primary)	-1.3%	[-1.3%, -1.3%]	1
Improvements ✅ (secondary)	-3.9%	[-3.9%, -3.9%]	1
All ❌✅ (primary)	2.5%	[-1.3%, 10.4%]	11

Cycles

Results (primary 2.3%, secondary 2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.3%, 2.3%]	1
Regressions ❌ (secondary)	3.9%	[2.9%, 4.7%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	2.3%	[2.3%, 2.3%]	1

Binary size

Results (primary 0.0%, secondary -0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	0.5%	[0.4%, 0.6%]	4
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	3
Improvements ✅ (secondary)	-1.9%	[-7.5%, -0.1%]	5
All ❌✅ (primary)	0.0%	[-0.0%, 0.2%]	4

Bootstrap: 476.516s -> 477.213s (0.15%)
Artifact size: 390.37 MiB -> 390.36 MiB (-0.00%)

bors · 2025-10-23T09:16:03Z

☔ The latest upstream changes (presumably #147793) made this pull request unmergeable. Please resolve the merge conflicts.

cjgillot · 2026-05-03T22:23:45Z

@bors try @rust-timer queue

[EXPERIMENT] Introduce `TypingMode::Codegen` to avoid layout cycles

rust-log-analyzer · 2026-05-03T22:46:24Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

tests/ui/should_impl_trait/method_list_2.rs (revision `edition2021`) ... ok
tests/ui/crashes/third-party/conf_allowlisted.rs ... ok

FAILED TEST: tests/ui/large_futures.rs
command: CLIPPY_CONF_DIR="tests" RUSTC_ICE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "--error-format=json" "--emit=metadata" "-Aunused" "-Ainternal_features" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Dwarnings" "-Ldependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "--sysroot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/tests/ui" "tests/ui/large_futures.rs" "--extern" "futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libfutures-09ec51524b5a0003.rlib" "--extern" "futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libfutures-09ec51524b5a0003.rmeta" "--extern" "itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libitertools-5279005a55e89a2e.rlib" "--extern" "itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libitertools-5279005a55e89a2e.rmeta" "--extern" "libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/liblibc-137b6571f3065622.rlib" "--extern" "libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/liblibc-137b6571f3065622.rmeta" "--extern" "parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libparking_lot-c4eeaa911c2dba70.rlib" "--extern" "parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libparking_lot-c4eeaa911c2dba70.rmeta" "--extern" "quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libquote-7103138ffc8c99e3.rlib" "--extern" "quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libquote-7103138ffc8c99e3.rmeta" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libregex-769e2d20ce236b92.rlib" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libregex-769e2d20ce236b92.rmeta" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libserde-3a023c4961ed4b17.rlib" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libserde-3a023c4961ed4b17.rmeta" "--extern" "syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libsyn-45e74c8dc3b5aeb1.rlib" "--extern" "syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libsyn-45e74c8dc3b5aeb1.rmeta" "--extern" "tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libtokio-b0a0126256058a81.rlib" "--extern" "tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps/libtokio-b0a0126256058a81.rmeta" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/debug/deps" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/debug/deps" "--edition" "2024"

error: no output was emitted
Execute `./x test src/tools/clippy --bless` to remove `tests/ui/large_futures.stderr`

error: diagnostic code `clippy::large_futures` not found on line 13

rust-bors · 2026-05-04T00:33:51Z

☀️ Try build successful (CI)
Build commit: 7bf3ad1 (7bf3ad14920af19fbbbe356a5ebb7be3d73010d4, parent: ad3a598ca4bc7c68bcbbce3e0d3be9a7618df190)

rust-timer · 2026-05-04T01:57:30Z

Finished benchmarking commit (7bf3ad1): comparison URL.

Overall result: ❌ regressions - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.2%, 1.2%]	75
Regressions ❌ (secondary)	1.2%	[0.2%, 9.8%]	81
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	1
Improvements ✅ (secondary)	-0.4%	[-0.7%, -0.3%]	7
All ❌✅ (primary)	0.5%	[-0.1%, 1.2%]	76

Max RSS (memory usage)

Results (primary 1.6%, secondary 1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.6%	[0.7%, 4.3%]	12
Regressions ❌ (secondary)	2.6%	[0.4%, 6.7%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.4%	[-1.6%, -1.1%]	2
All ❌✅ (primary)	1.6%	[0.7%, 4.3%]	12

Cycles

Results (primary -3.0%, secondary 2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[0.5%, 8.9%]	18
Improvements ✅ (primary)	-3.0%	[-3.5%, -2.5%]	2
Improvements ✅ (secondary)	-0.6%	[-0.7%, -0.5%]	2
All ❌✅ (primary)	-3.0%	[-3.5%, -2.5%]	2

Binary size

Results (primary 0.3%, secondary -0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	1
Regressions ❌ (secondary)	0.4%	[0.3%, 0.5%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.9%	[-7.3%, -0.1%]	4
All ❌✅ (primary)	0.3%	[0.3%, 0.3%]	1

Bootstrap: 495.343s -> 498.406s (0.62%)
Artifact size: 394.42 MiB -> 395.17 MiB (0.19%)

This comment has been minimized.

Sign in to view

rust-bors Bot added a commit that referenced this pull request Aug 16, 2025

Auto merge of #145477 - cjgillot:codegen-mode, r=<try>

34dd67f

[EXPERIMENT] Introduce `TypingMode::Codegen` to avoid layout cycles

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 16, 2025

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Aug 16, 2025

cjgillot force-pushed the codegen-mode branch from a35a84a to 3f6e4db Compare August 16, 2025 14:30

This comment has been minimized.

Sign in to view

rust-bors Bot added a commit that referenced this pull request Aug 16, 2025

Auto merge of #145477 - cjgillot:codegen-mode, r=<try>

4e9488c

[EXPERIMENT] Introduce `TypingMode::Codegen` to avoid layout cycles

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 16, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 16, 2025

This comment has been minimized.

Sign in to view

cjgillot force-pushed the codegen-mode branch from 7bde1fe to bdb8bf2 Compare August 23, 2025 18:31

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 17, 2025

cjgillot force-pushed the codegen-mode branch from 1cfa179 to 5c02767 Compare October 19, 2025 02:12

This comment has been minimized.

Sign in to view

cjgillot force-pushed the codegen-mode branch from 5c02767 to ca9c354 Compare May 3, 2026 20:06

cjgillot added 3 commits May 3, 2026 20:25

Introduce TypingMode::Codegen.

8c2f5c4

Reuse result from eval_to_const_value_raw.

23c82d5

Reuse cached layout from PostAnalysis when possible.

7628fd6

cjgillot force-pushed the codegen-mode branch from ca9c354 to 480b6d5 Compare May 3, 2026 20:41

This comment has been minimized.

Sign in to view

cjgillot added 8 commits May 3, 2026 21:43

Do not compute coroutine layout in non-Codegen typing mode.

a628026

Perform KnownPanicsLint inside coroutines.

17ae260

Perform RemoveZsts inside coroutines.

e0316dd

Perform SROA inside coroutines.

44550e2

Allow inlining into coroutines.

f4ceed7

Perform jump-threading inside coroutines.

1df27e2

Return fallback size and align when static layout is error.

85d2113

Perform GVN inside coroutines.

0f75d27

cjgillot force-pushed the codegen-mode branch from 480b6d5 to 0f75d27 Compare May 3, 2026 21:44

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 3, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request May 3, 2026

Auto merge of #145477 - cjgillot:codegen-mode, r=<try>

7bf3ad1

[EXPERIMENT] Introduce `TypingMode::Codegen` to avoid layout cycles

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 4, 2026

Uh oh!

Conversation

cjgillot commented Aug 16, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjgillot commented Aug 16, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 16, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Aug 16, 2025

Overall result: ❌ regressions - please read the text below

Uh oh!

cjgillot commented Aug 16, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Aug 16, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-timer commented Aug 16, 2025

Overall result: ❌ regressions - please read the text below

Uh oh!

This comment has been minimized.

bors commented Aug 23, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Oct 17, 2025

Overall result: ❌ regressions - please read the text below

Uh oh!

This comment has been minimized.

bors commented Oct 23, 2025

Uh oh!

This comment has been minimized.

cjgillot commented May 3, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-log-analyzer commented May 3, 2026

Uh oh!

rust-bors Bot commented May 4, 2026

Uh oh!

This comment has been minimized.

rust-timer commented May 4, 2026

Overall result: ❌ regressions - please read:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cjgillot commented Aug 16, 2025 •

edited by rustbot

Loading