Fix FormattingOptions instantiation with Default#135977
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 25, 2025
Merged
Fix FormattingOptions instantiation with Default#135977bors merged 1 commit intorust-lang:masterfrom
FormattingOptions instantiation with Default#135977bors merged 1 commit intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fillvalue by default should be set to' '(space), but the current implementation uses#[derive(Default)]which sets it to\0.Note that
FormattingOptionsis being released as part of 1.85 (unstable) - so this might warrant a backport to that branch.Tracking issue: #118117
Follow up from #118159
CC: @EliasHolzmann @programmerjake
r? @m-ou-se