default_constructed_unit_structs -> is_unit_struct#16873
Closed
nyurik wants to merge 1 commit intorust-lang:masterfrom
Closed
default_constructed_unit_structs -> is_unit_struct#16873nyurik wants to merge 1 commit intorust-lang:masterfrom
nyurik wants to merge 1 commit intorust-lang:masterfrom
Conversation
Move is_unit_struct into clippy_utils to use it in the new lint default_mismatches_new
rustbot
added
the
S-waiting-on-review
Member
|
Please don't create PRs in isolation. For example, this PR has no justification by itself. This should be a separate commit in a PR where this refactoring makes sense. |
Contributor
Author
|
@samueltardieu same here - this PR is also a commit in #16531, so i'll delete it here |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move is_unit_struct into clippy_utils to use it in the new lint default_mismatches_new
Per @samueltardieu in #16531 (review)
r? @samueltardieu
changelog: none