Skip to content

[AIX] Use zlibNX if available. #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amy-kwan wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[AIX] Use zlibNX if available. #268

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45b0a19
[AIX] Use zlibNX if available.
amy-kwan Apr 22, 2026
8db8609
Fix zlibNX handling to honor static mode and validate linkability
amy-kwan Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,19 @@ fn main() {
return;
}

// On AIX, use zlibNX if available.
if target.contains("aix") {
let zlibNX_lib = "/usr/opt/zlibNX/lib";
let zlibNX_include = "/usr/opt/zlibNX/include";
if std::path::Path::new(zlibNX_lib).join("libz.a").exists() &&
std::path::Path::new(zlibNX_include).join("zlib.h").exists() {
println!("cargo:rustc-link-search=native={}", zlibNX_lib);
println!("cargo:rustc-link-lib=z");
println!("cargo:include={}", zlibNX_include);
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local variable names zlibNX_lib/zlibNX_include don’t follow Rust’s usual snake_case naming used throughout this file (e.g., want_static, host_and_target_contain). Consider renaming to snake_case (e.g., zlibnx_lib, zlibnx_include or zlibnx_lib_dir, zlibnx_include_dir) for consistency.

Suggested change
let zlibNX_lib = "/usr/opt/zlibNX/lib";
let zlibNX_include = "/usr/opt/zlibNX/include";
if std::path::Path::new(zlibNX_lib).join("libz.a").exists() &&
std::path::Path::new(zlibNX_include).join("zlib.h").exists() {
println!("cargo:rustc-link-search=native={}", zlibNX_lib);
println!("cargo:rustc-link-lib=z");
println!("cargo:include={}", zlibNX_include);
let zlibnx_lib = "/usr/opt/zlibNX/lib";
let zlibnx_include = "/usr/opt/zlibNX/include";
if std::path::Path::new(zlibnx_lib).join("libz.a").exists() &&
std::path::Path::new(zlibnx_include).join("zlib.h").exists() {
println!("cargo:rustc-link-search=native={}", zlibnx_lib);
println!("cargo:rustc-link-lib=z");
println!("cargo:include={}", zlibnx_include);

Copilot uses AI. Check for mistakes.
return;
}
}

let want_static = should_link_static();
// Don't run pkg-config if we're linking statically (we'll build below) and
// also don't run pkg-config on FreeBSD/DragonFly. That'll end up printing
Expand Down
Loading