Skip to content

Add end-to-end tests showing use of Repository::statuses()#1251

Open
DanielEScherzer wants to merge 1 commit into
rust-lang:mainfrom
DanielEScherzer:repo-status-e2e
Open

Add end-to-end tests showing use of Repository::statuses()#1251
DanielEScherzer wants to merge 1 commit into
rust-lang:mainfrom
DanielEScherzer:repo-status-e2e

Conversation

@DanielEScherzer
Copy link
Copy Markdown
Contributor

Specifically how it analyses files and should be used to determine if a repo is "clean".

Closes #1145

Specifically how it analyses files and should be used to determine if a repo is
"clean".

Closes rust-lang#1145
@rustbot rustbot added the S-waiting-on-review Status: Waiting on review label May 12, 2026
Copy link
Copy Markdown
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I don't think this really resolve the confusion of #1145, we at least have a file can point at when confusion arises. Thanks!

View changes since this review

Comment thread tests/end_to_end.rs
std::os::unix::fs::symlink(to, from).unwrap();

#[cfg(windows)]
std::os::windows::fs::symlink_file(to, from).unwrap();
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On windows this requires developer mode privileges btw. If we have already done this, fine, if not, better make this skippable locally and enforced in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Waiting on review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

repo.state() returns Clean when actually dirty

3 participants