Skip to content

ignore tests which will be broken by never type stabilization #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WaffleLapkin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ignore tests which will be broken by never type stabilization #383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/rust-2024/never-type-fallback.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ The fix is to specify the type explicitly so that the fallback type is not used.

One of the most common patterns broken by this change is using `f()?;` where `f` is generic over the `Ok`-part of the return type:

```rust
```rust,ignore
# #![allow(dependency_on_unit_never_type_fallback)]
# fn outer<T>(x: T) -> Result<T, ()> {
fn f<T: Default>() -> Result<T, ()> {
Expand Down Expand Up @@ -98,7 +98,7 @@ f::<()>()?;

Another relatively common case is panicking in a closure:

```rust,should_panic
```rust,should_panic,ignore
# #![allow(dependency_on_unit_never_type_fallback)]
trait Unit {}
impl Unit for () {}
Expand All @@ -125,7 +125,7 @@ run(|| -> () { panic!() });

A similar case to that of `f()?` can be seen when using a `!`-typed expression in one branch and a function with an unconstrained return type in the other:

```rust
```rust,ignore
# #![allow(dependency_on_unit_never_type_fallback)]
if true {
Default::default()
Expand Down