Open
Conversation
Properly unset RUMP_SEVER variable every time it is exported.
Member
|
The reason they're in cwd is so that they don't conflict with other ongoing tests on the name host. So, at least use $$ and apply a cleanup trap if you want to move them to /tmp. Also, pullup is gated on passing travis (even if the change itself didn't break travis). |
Author
|
Thank you for your answer. Something like that? (I removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion:
3 tests failed in my environment because
rump server init failed: File name too long.Actually, the limit for a unix socket's path length is quite small.
For example on NetBSD, according to unix(4) man page:
while /usr/include/ufs/ffs/fs.h
Can we put sockets in /tmp?
Or maybe it is kind of odd to patch this because I work in paths far from /