Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates RubyGems’ YAML safe-loading behavior/tests to align error types with Psych and to ensure Gem::Version::Requirement tags can be loaded when embedded in gemspec YAML.
Changes:
- Switch unknown-tag handling from
ArgumentErrortoPsych::DisallowedClass(and refactor intoraise_disallowed_class!). - Adjust tag validation/permitted-classes handling in
Gem::YAMLSerializer::Builder. - Add a regression test ensuring
Gem::Version::Requirementis accepted inGem::Specification#required_ruby_version.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/rubygems/test_gem_safe_yaml.rb | Updates/extends SafeYAML tests for unknown tags and version-requirement tag handling. |
| lib/rubygems/yaml_serializer.rb | Refactors Builder tag validation and error raising behavior for disallowed classes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
lib/rubygems/yaml_serializer.rb
Outdated
| else | ||
| raise Psych::DisallowedClass, "Tried to load unspecified class: #{tag}" | ||
| end | ||
| return if @permitted_classes.empty? |
Comment on lines
+426
to
427
| @permitted_classes = permitted_classes.map {|c| "!ruby/object:#{c}" } | ||
| @permitted_symbols = permitted_symbols |
| yaml = "!ruby/object:MyCustomClass\nfoo: bar\n" | ||
| assert_raise(ArgumentError) do | ||
| assert_raise(Psych::DisallowedClass) do | ||
| yaml_load(yaml, permitted_classes: ["MyCustomClass"]) |
… Psych Align YAMLSerializer's `permitted_classes` validation with Psych's whitelist semantics: an empty `permitted_classes` list denies all tagged classes, matching `Psych::ClassLoader::Restricted` behavior. - Rename `@permitted_tags` to `@permitted_classes` and simplify initialization - Extract `raise_disallowed_class!` from `validate_tag!` for clarity - Move `check_anchor!` before `validate_tag!` in `build_mapping` - Add test for `Gem::Version::Requirement` tag used by old gems like `escape` Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Old gems such as
escapeuse the legacy!ruby/object:Gem::Version::RequirementYAML tag which is an alias forGem::Requirement. This causedPsych::DisallowedClasserrors when installing these gems with the pure Ruby YAML parser.What is your fix for the problem, implemented in this PR?
Add
Gem::Version::Requirementto the Builder's case statement so it is handled bybuild_requirementMake sure the following tasks are checked