Merged
Conversation
Add dependency of mutex_m / bigdecimal to address LoadError for Ruby 3.4 Add dependency of concurrent-ruby v1.3.4 to address NameError uninitialized constant for Rails 7.0 or below
…fied minor version
radar
approved these changes
Oct 27, 2025
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request adds Ruby 3.4 to the CI matrix.
Additionally, it fixes the Rails version specification in gemfiles so that CI runs against the intended minor version.
Details
Add dependencies for Ruby 3.4 in CI Gemfiles
Since
mutex_mandbigdecimalcause the following errors on Ruby 3.4, dependencies have been added to the Gemfiles for each Rails version in CI where these errors occur.This is because these gems were moved from
default gemstobundled gemsin Ruby 3.4.https://github.com/ruby/ruby/blob/v3_4_0/NEWS.md?plain=1#L333-L352
Fix CI Error of
uninitialized constant ActiveSupport::LoggerThreadSafeLevel::Logger (NameError)for rails 7.0 or belowconcurrent-rubyv1.3.4 has been added for compatibility with Rails versions <= 7.0.This resolves an error that occurs with Rails <= 7.0 and
concurrent-rubyv1.3.5:The error details are as follows:
https://github.com/ruby-i18n/i18n/actions/runs/18092846741/job/51477245834
Fix Rails version specification in gemfiles
In CI, jobs such as
build (3.3, gemfiles/Gemfile.rails-7.1.x)were running against Rails 7.2 instead of Rails 7.1.This Pull Request updates the version specification to ensure that the intended Rails minor version is used.
Example change (Gemfile.rails-7.1.x):
Before this fix, the Rails 7.1 CI lockfile was already pulling in Rails 7.2:
https://github.com/ruby-i18n/i18n/actions/runs/18093519210/job/51479436380