Skip to content

Remove redundant helper that was making a wrong impression we cover Include/Exclude in specs #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pirj wants to merge 1 commit into from
Closed

Remove redundant helper that was making a wrong impression we cover Include/Exclude in specs #1421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions spec/rubocop/cop/rspec/factory_bot/attribute_defined_statically_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
# frozen_string_literal: true

RSpec.describe RuboCop::Cop::RSpec::FactoryBot::AttributeDefinedStatically do
def inspected_source_filename
'spec/factories.rb'
end

it 'registers an offense for offending code' do
expect_offense(<<-RUBY)
FactoryBot.define do
Expand Down
4 changes: 0 additions & 4 deletions spec/rubocop/cop/rspec/factory_bot/factory_class_name_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
# frozen_string_literal: true

RSpec.describe RuboCop::Cop::RSpec::FactoryBot::FactoryClassName do
def inspected_source_filename
'spec/factories.rb'
end

context 'when passing block' do
it 'flags passing a class' do
expect_offense(<<~RUBY)
Expand Down
2 changes: 1 addition & 1 deletion spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ module SpecHelper
# We should take their advice!
config.raise_on_warning = true

config.include(ExpectOffense)
config.include(RuboCop::RSpec::ExpectOffense)

config.include_context 'with default RSpec/Language config', :config
config.include_context 'smoke test', type: :cop_spec
Expand Down
27 changes: 0 additions & 27 deletions spec/support/expect_offense.rb
View file
Open in desktop

This file was deleted.