Add FactoryBot/AssociationStyle cop#33
Merged
pirj merged 6 commits intorubocop:masterfrom May 15, 2023
Merged
Conversation
13 tasks
8900b1b to
76baf4e
Compare
pirj
reviewed
May 13, 2023
94721af to
168c94f
Compare
pirj
approved these changes
May 14, 2023
Member
pirj
left a comment
There was a problem hiding this comment.
Looks great, thank you!
I've applied some cosmetic clean-up.
pirj
reviewed
May 14, 2023
Member
Locally 🧐 Updated to the latest 1.51.0, but still the same. It seems to be PS most probably caused by |
`traits:` is not a valid `association` option
Member
|
@ydah Are you ok with this? |
Member
|
Thank you, @r7kamura ! :combo: 1️⃣ 2️⃣ 3️⃣ 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreated from the following pull request:
RSpec/FactoryBot/AssociationStylecop rubocop-rspec#1414Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml.Enabled: pendinginconfig/default.yml.VersionAdded: "<<next>>"indefault/config.yml.If you have modified an existing cop's configuration options:
VersionChanged: "<<next>>"inconfig/default.yml.