Open
Conversation
jneen
force-pushed
the
maint.igor-pro-manual-builtins
branch
from
baf32e1 to
50c6de6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #2221.
@MichaelHuth Since you indicated you would be willing to manually maintain the builtins file, I've added your contact to the top. Please let me know if it should be changed!
Other changes/fixes to the IgorPro lexer:
set.includes?(m[0].downcase)on sets that were not all downcased, meaning we were missing many functions and operations that included capital letters. Also made it only downcase the token once.objectregexp, as I presume it's intended to capture all word characters and., but the*?\bat the end meant it would stop before the first../#{foo}/in favour of just using the regexp that is in scope.