Skip to content

Add BatteryStates msg #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YaraShahin wants to merge 3 commits into
base: rolling
Choose a base branch
from
+5 −0
Open

Add BatteryStates msg #302

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f445ee5
add BatteryStates msg
YaraShahin Oct 24, 2025
8f074b1
add comment for msg
YaraShahin Oct 24, 2025
51178c8
rename to BatteryStateArray
YaraShahin Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/APIReviewFoxy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ Msg


* [https://github.com/ros2/common_interfaces/blob/master/sensor_msgs/msg/BatteryState.msg](https://github.com/ros2/common_interfaces/blob/master/sensor_msgs/msg/BatteryState.msg)
* [https://github.com/ros2/common_interfaces/blob/master/sensor_msgs/msg/BatteryStates.msg](https://github.com/ros2/common_interfaces/blob/master/sensor_msgs/msg/BatteryStates.msg)
* [https://github.com/ros2/common_interfaces/blob/master/sensor_msgs/msg/CameraInfo.msg](https://github.com/ros2/common_interfaces/blob/master/sensor_msgs/msg/CameraInfo.msg)
* [https://github.com/ros2/common_interfaces/blob/master/sensor_msgs/msg/ChannelFloat32.msg](https://github.com/ros2/common_interfaces/blob/master/sensor_msgs/msg/ChannelFloat32.msg)
* [https://github.com/ros2/common_interfaces/blob/master/sensor_msgs/msg/CompressedImage.msg](https://github.com/ros2/common_interfaces/blob/master/sensor_msgs/msg/CompressedImage.msg)
Expand Down
1 change: 1 addition & 0 deletions sensor_msgs/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ find_package(std_msgs REQUIRED)

set(msg_files
"msg/BatteryState.msg"
"msg/BatteryStates.msg"
Copy link
Copy Markdown
Member

@christophebedard christophebedard Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧇 I'm requesting a review from Michael, but I can already share one bit of feedback: based on existing naming conventions, this should be msg/BatteryStateArray.msg.

Copy link
Copy Markdown
Author

@YaraShahin YaraShahin Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

"msg/CameraInfo.msg"
"msg/ChannelFloat32.msg"
"msg/CompressedImage.msg"
Expand Down
1 change: 1 addition & 0 deletions sensor_msgs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ This package provides some common C++ functionality relating to manipulating a c

## Messages (.msg)
* [BatteryState](msg/BatteryState.msg): Describes the power state of the battery.
* [BatteryStates](msg/BatteryStates.msg): An array of BatteryState messages.
* [CameraInfo](msg/CameraInfo.msg): Meta information for a camera.
* [ChannelFloat32](msg/ChannelFloat32.msg): Holds optional data associated with each point in a PointCloud message.
* [CompressedImage](msg/CompressedImage.msg): A compressed image.
Expand Down
2 changes: 2 additions & 0 deletions sensor_msgs/msg/BatteryStates.msg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# This message publishes values for multiple batteries at once.
BatteryState[] battery_states