Skip to content

fix(substitution_args.py): _resolve_args() not finding commands #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhaschke merged 4 commits into from
Mar 17, 2026
+2 −2
Merged

fix(substitution_args.py): _resolve_args() not finding commands #380

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eb984bb
fix(substitution_args.py): _resolve_args() not finding commands
Amronos Mar 16, 2026
4842ef3
refactor: Use .strip() to fix the bug
Amronos Mar 17, 2026
d088535
refactor: Fix the bug by splitting on any whitespace
Amronos Mar 17, 2026
09ea855
cleanup
rhaschke Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions xacro/substitution_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@

import math
import os
import shlex
import yaml

from io import StringIO
Expand Down Expand Up @@ -333,10 +334,10 @@ def _resolve_args(arg_str, context, commands):
resolved = arg_str
for a in _collect_args(arg_str):
splits = [s for s in a.split(' ') if s]
Copy link
Copy Markdown
Contributor

@rhaschke rhaschke Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check wheather splitting on any whitespace already resolves the problem too:

Suggested change
splits = [s for s in a.split(' ') if s]
splits = [s for s in a.split() if s]

Copy link
Copy Markdown
Contributor Author

@Amronos Amronos Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That works. Fixed in d088535.

if not splits[0] in valid:
if splits[0].strip() not in valid:
raise SubstitutionException('Unknown substitution command [%s]. '
'Valid commands are %s' % (a, valid))
command = splits[0]
'Valid commands are %s' % (splits[0], valid))
command = splits[0].strip()
args = splits[1:]
if command in commands:
resolved = commands[command](resolved, a, args, context)
Expand Down