[cmake] Handle absolute install_dir in relative RPATH resolution#21786
Open
guitargeek wants to merge 1 commit intoroot-project:masterfrom
Open
[cmake] Handle absolute install_dir in relative RPATH resolution#21786guitargeek wants to merge 1 commit intoroot-project:masterfrom
guitargeek wants to merge 1 commit intoroot-project:masterfrom
Conversation
`ROOT_APPEND_LIBDIR_TO_INSTALL_RPATH` assumed that `install_dir` is always relative to `CMAKE_INSTALL_PREFIX` when computing the relative path to `CMAKE_INSTALL_FULL_LIBDIR`. However, some build environments (e.g. Fedora or Nix) pass an absolute `CMAKE_INSTALL_LIBDIR`, which results in an incorrect relative path. Fix this by detecting whether `install_dir` is absolute and using it directly as the base directory when computing the relative path.
Test Results 22 files 22 suites 3d 7h 22m 40s ⏱️ For more details on these failures, see this check. Results for commit f073c73. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROOT_APPEND_LIBDIR_TO_INSTALL_RPATHassumed thatinstall_diris always relative toCMAKE_INSTALL_PREFIXwhen computing the relative path toCMAKE_INSTALL_FULL_LIBDIR. However, some build environments (e.g. Fedora or Nix) pass an absoluteCMAKE_INSTALL_LIBDIR, which results in an incorrect relative path.Fix this by detecting whether
install_diris absolute and using it directly as the base directory when computing the relative path.Thanks to the ROOT/Nix user at GSI reporting this issue!