Skip to content

feat(sucrase): add jsxRuntime config option#1848

Closed
joeuy wants to merge 2 commits intorollup:masterfrom
joeuy:jch--add-jsx-runtime
Closed

feat(sucrase): add jsxRuntime config option#1848
joeuy wants to merge 2 commits intorollup:masterfrom
joeuy:jch--add-jsx-runtime

Conversation

@joeuy
Copy link
Copy Markdown

@joeuy joeuy commented Feb 22, 2025

Rollup Plugin Name: sucrase

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers: #1544 (reply in thread)

Description

This PR adds jsxRuntime config option for sucrase

@joeuy joeuy requested a review from shellscape as a code owner February 22, 2025 03:46
@joeuy joeuy changed the title add jsx runtime config to rollup/sucrase add jsxRuntime config to rollup/sucrase Feb 22, 2025
@joeuy
Copy link
Copy Markdown
Author

joeuy commented Mar 2, 2025

@shellscape looks good?

@shellscape
Copy link
Copy Markdown
Collaborator

@joeuy as the PR template states, we don't accept fix or feature PRs without tests. Please add a test specifically for this addition. This is not an other, this is a feature.

@shellscape shellscape changed the title add jsxRuntime config to rollup/sucrase feat(sucrase): add jsxRuntime config option Mar 6, 2025
@shellscape
Copy link
Copy Markdown
Collaborator

Closing as abandoned.

@shellscape shellscape closed this Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants