Skip to content

fix(node-resolve): add ignoreSideEffectsForRoot to exported interface #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shellscape merged 2 commits into from
Mar 11, 2025
Merged

fix(node-resolve): add ignoreSideEffectsForRoot to exported interface #1841

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9995dcc
fix(node-resolve): add `ignoreSideEffectsForRoot` to exported interface
younggglcy Feb 1, 2025
9b936c4
test: add type tests
younggglcy Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/node-resolve/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,9 @@ rootDir: path.join(process.cwd(), '..')

### `ignoreSideEffectsForRoot`

Type: `Boolean`<br>
Default: `false`

If you use the `sideEffects` property in the package.json, by default this is respected for files in the root package. Set to `true` to ignore the `sideEffects` configuration for the root package.

### `allowExportsFolderMapping`
Expand Down
7 changes: 7 additions & 0 deletions packages/node-resolve/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,13 @@ export interface RollupNodeResolveOptions {
*/
rootDir?: string;

/**
* If you use the `sideEffects` property in the package.json, by default this is respected for files in the root package. Set to `true` to ignore the `sideEffects` configuration for the root package.
*
* @default false
*/
ignoreSideEffectsForRoot?: boolean;

/**
* Allow folder mappings in package exports (trailing /)
* This was deprecated in Node 14 and removed with Node 17, see DEP0148.
Expand Down