Switch webrtc from multiprocessing to threading#2154
Draft
Conversation
Collaborator
|
I'd vote for adding 3rd option to run workers - we can have 3 options coexisting and turned on based on user requirements |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The local WebRTC worker (
/initialise_webrtc_worker) was crashing with SIGSEGV on macOS becausemultiprocessing.get_context("spawn")forces a child process to re-import and re-initialize all C extensions (PyTorch, av, aiortc), which segfaults in native code.Fix: Replace the multiprocessing subprocess with a
threading.Threadrunning its ownasyncio.new_event_loop()for the local (non-Modal) code path. The SDP answer is communicated back viaasyncio.Future+call_soon_threadsafe. This avoids subprocess spawn entirely, eliminating the segfault. The Modal (production) path is unchanged.Also added defensive error handling in
cpu.pyso that if the multiprocessing path is ever used, unhandled exceptions are logged and sent back through the pipe instead of silently killing the child process.Type of Change
Testing
Test details:
/initialise_webrtc_workerno longer crashes with SIGSEGV on macOSChecklist