Skip to content

fix(sqlparser): correctly parse delimiters inside dollar-quoted string#25599

Open
Standing-Man wants to merge 4 commits into
risingwavelabs:mainfrom
Standing-Man:dollar-quoted-string
Open

fix(sqlparser): correctly parse delimiters inside dollar-quoted string#25599
Standing-Man wants to merge 4 commits into
risingwavelabs:mainfrom
Standing-Man:dollar-quoted-string

Conversation

@Standing-Man
Copy link
Copy Markdown
Contributor

@Standing-Man Standing-Man commented May 8, 2026

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

problem: The current sqlparser behavior incorrectly terminates or errors on nested dollar-quote-like content inside a dollar-quoted string, instead of handling it as literal content.

The implementation now treats all characters inside both untagged and tagged dollar-quoted strings as literal string content.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

Signed-off-by: StandingMan <jmtangcs@gmail.com>
Signed-off-by: StandingMan <jmtangcs@gmail.com>
@Standing-Man
Copy link
Copy Markdown
Contributor Author

Hi @chenzl25 and @xiangjinwu, could you please take a look when you have a moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: support Dollar-Quoted String Constants bug(sqlparser): dollar-quoted string cannot be nested

1 participant