fix(sqlparser): correctly parse delimiters inside dollar-quoted string#25599
Open
Standing-Man wants to merge 4 commits into
Open
fix(sqlparser): correctly parse delimiters inside dollar-quoted string#25599Standing-Man wants to merge 4 commits into
Standing-Man wants to merge 4 commits into
Conversation
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Contributor
Author
|
Hi @chenzl25 and @xiangjinwu, could you please take a look when you have a moment? |
Signed-off-by: StandingMan <jmtangcs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
problem: The current sqlparser behavior incorrectly terminates or errors on nested dollar-quote-like content inside a dollar-quoted string, instead of handling it as literal content.
The implementation now treats all characters inside both untagged and tagged dollar-quoted strings as literal string content.
Checklist
Documentation
Release note