feat: 5/7 route role membership through frontend#25525
Open
tabVersion wants to merge 2 commits intoralph/rbac-split-04-meta-revoke-drop-authorityfrom
Open
feat: 5/7 route role membership through frontend#25525tabVersion wants to merge 2 commits intoralph/rbac-split-04-meta-revoke-drop-authorityfrom
tabVersion wants to merge 2 commits intoralph/rbac-split-04-meta-revoke-drop-authorityfrom
Conversation
This stack layer connects role grant and revoke behavior through frontend handlers, privilege checks, membership cache refresh, and the session surfaces needed by role dispatch. It also carries the SET ROLE/session plumbing required to keep the restored dispatch code compile-safe.\n\nConstraint: Frontend GRANTED BY and role dispatch depend on membership snapshots and session user accessors.\nRejected: Keep handler dispatch as parser-only stubs | would prevent testing the meta authority added by the previous PRs.\nConfidence: medium\nScope-risk: moderate\nDirective: Catalog compatibility and system function snapshots still belong to the final stack layer.\nTested: cargo fmt --check; cargo check -p risingwave_frontend\nNot-tested: Full role_dispatch integration test suite
7 tasks
tabVersion
changed the title
github-actions
Bot
added
type/feature
8 tasks
Actual SELECT/UPDATE binding now uses the same role-membership inheritance helper as session privilege checks instead of checking only direct ACLs on the current role. This keeps runtime table access aligned with the effective privilege model introduced in the frontend role-dispatch layer. Constraint: The fix belongs in PR #25525 because that stack layer owns frontend privilege checks, effective privilege helpers, and membership cache plumbing. Rejected: Put this in #25527 catalog compatibility | that would leave actual query execution broken until the final catalog-only layer. Confidence: high Scope-risk: narrow Directive: Keep pg_catalog/system-function compatibility in #25527; this commit only wires actual binder checks to effective privileges. Tested: cargo fmt --check; git diff --check; cargo check -p risingwave_frontend; cargo test -p risingwave_frontend --test role_dispatch; ./risedev slt-clean './e2e_test/ddl/role_inherited_privilege.slt'; ./risedev slt './e2e_test/ddl/role_inherited_privilege.slt' Not-tested: Full workspace CI Co-authored-by: OmX <omx@oh-my-codex.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: 5/7 for splitting
ralph/rbac-postgres-final-alignmentontoorigin/main.Base:
ralph/rbac-split-04-meta-revoke-drop-authorityNext:
ralph/rbac-split-06-set-role-session-semanticsScope
Out of scope
Tests
cargo fmt --checkgit diff --checkcargo check -p risingwave_frontendcargo test -p risingwave_frontend --test role_dispatch./risedev slt-clean './e2e_test/ddl/role_inherited_privilege.slt'./risedev slt './e2e_test/ddl/role_inherited_privilege.slt'