Remove py-show and use pyproject-external project #5
Remove py-show and use pyproject-external project #5rgommers merged 17 commits intorgommers:mainfrom
py-show and use pyproject-external project #5Conversation
jaimergp
changed the title
py-show and use external-metadata project py-show and use pyproject-external project
|
We have achieved parity with So this is ready for review @rgommers |
rgommers
left a comment
rgommers
left a comment
There was a problem hiding this comment.
LGTM, thanks Jaime. Happy to merge as is. Why git had to be added I'm not sure about, so let's capture the answer here in case it's useful in the future.
| python -m pyproject_external --output=mapped $cli_args | ||
| echo "Install command:" | ||
| set +x | ||
| eval "$(python -m pyproject_external --output=command $cli_args)" |
| - uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4.1.0 | ||
|
|
||
| - name: Install system Python | ||
| - name: Install system Python and git |
There was a problem hiding this comment.
The Docker images don't have it, and some of our dependencies are installing Python packages from github repositories because they are not released on PyPI yet, more specifically:
I tried using a github archive for that but it failed due to setuptools-scm shenanigans.
There was a problem hiding this comment.
Ah, that explains it - makes sense. It's not an issue at all to have it here, just good to know it can be dropped again in principle ones tooling issues are resolved. I kept it out on purpose because git can also be a runtime dependency.
| "dep:virtual/compiler/c", | ||
| ] | ||
|
|
||
| host-requires = [ |
There was a problem hiding this comment.
good catch, this was a bug before
2 participants
I also cleaned the root directory a little bit.