Skip to content

fix: remove remote uri setting for cancel #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shenjinti merged 1 commit into from
Apr 13, 2026
+2 −6
Merged

fix: remove remote uri setting for cancel #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/dialog/dialog.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ impl TransactionHandle {
/// * `WaitAck` - Server dialog waiting for ACK after sending 2xx response
/// * `Confirmed` - Dialog is established and confirmed (2xx response received/sent and ACK sent/received)
/// * `Updated` - Dialog received an UPDATE request
/// * `Notify` - Dialog received a NOTIFY request
/// * `Notify` - Dialog received a NOTIFY request
/// * `Info` - Dialog received an INFO request
/// * `Options` - Dialog received an OPTIONS request
/// * `Terminated` - Dialog has been terminated
Expand Down Expand Up @@ -219,7 +219,7 @@ impl ReferStatus {
/// // Handle server dialog
/// },
/// Dialog::ClientInvite(client_dialog) => {
/// // Handle client dialog
/// // Handle client dialog
/// },
/// Dialog::ServerSubscription(server_dialog) => {
/// // Handle server subscription dialog
Expand Down Expand Up @@ -878,10 +878,6 @@ impl DialogInner {
let key = TransactionKey::from_request(&request, TransactionRole::Client)?;
let mut tx = Transaction::new_client(key, request, self.endpoint_inner.clone(), None);

if matches!(method, Method::Cancel) {
tx.destination = SipAddr::try_from(self.remote_uri.lock().clone()).ok();
}

if let Some(route) = tx.original.route_header() {
if let Some(first_route) = route.typed().ok() {
tx.destination = SipAddr::try_from(&first_route.uri).ok();
Expand Down
Loading